Remove max_hlevel from DFS #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not exposed in the dfs method so it always used the default value of 2, it was undocumented, and it was unclear if it provided any value.
This is no longer used.
Codecov Report
@@ Coverage Diff @@
## multipath-dfs-no-cycles #608 +/- ##
===========================================================
+ Coverage 96.35% 96.38% +0.03%
===========================================================
Files 119 119
Lines 9713 9605 -108
===========================================================
- Hits 9359 9258 -101
+ Misses 354 347 -7
Continue to review full report at Codecov.
|
kmax12
approved these changes
Jun 19, 2019
| if ((max_depth is None or self._get_depth(f) <= max_depth) and | ||
| (self.max_hlevel is None or | ||
| self._max_hlevel(f) <= self.max_hlevel)): | ||
| if max_depth is None or self._get_depth(f) <= max_depth: |
There was a problem hiding this comment.
I think we can replace self._get_depth(f) with f.get_depth(stop_at=self.seed_features) and remove self._get_depth
CJStadler
added a commit
that referenced
this pull request
Jun 21, 2019
For entitysets with multiple paths between two entities DFS will now create features through all paths. Entitysets with cycles in the directed graph are not supported. - Use feature.unique_name instead of hash in dicts - Change EntitySet.get_backward_entities and get_forward_entities to yield paths. - Add RelationshipPath which represents a directed path through relationships. - Add RelationshipPath.entities - Warn if dfs produces a feature multiple times - Remove max_hlevel from DFS (#608). - Remove EntitySet.find_path
Merged
johnnyheineken
pushed a commit
to johnnyheineken/featuretools
that referenced
this pull request
Jul 7, 2019
For entitysets with multiple paths between two entities DFS will now create features through all paths. Entitysets with cycles in the directed graph are not supported. - Use feature.unique_name instead of hash in dicts - Change EntitySet.get_backward_entities and get_forward_entities to yield paths. - Add RelationshipPath which represents a directed path through relationships. - Add RelationshipPath.entities - Warn if dfs produces a feature multiple times - Remove max_hlevel from DFS (alteryx#608). - Remove EntitySet.find_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not exposed in the
dfsmethod so it always used the defaultvalue of 2, it was undocumented, and it was unclear if it provided any
value.
Also remove
EntitySet.find_pathas it is no longer used.The base branch should be changed to
masterafter #600 is merged.