Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make median agg primitives ignore nans by default #61

Merged
merged 3 commits into from Jan 18, 2018
Merged

Conversation

kmax12
Copy link
Contributor

@kmax12 kmax12 commented Jan 8, 2018

This makes it consistent with other other aggregation primitives like Sum, Mean, and Std.

Note: I added a column to mock dataset in order to write test. I had to update a 2 other tests as a result.

@codecov-io
Copy link

codecov-io commented Jan 8, 2018

Codecov Report

Merging #61 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #61      +/-   ##
=========================================
+ Coverage   87.19%   87.2%   +0.01%     
=========================================
  Files          74      74              
  Lines        6973    6980       +7     
=========================================
+ Hits         6080    6087       +7     
  Misses        893     893
Impacted Files Coverage Δ
tests/entityset_tests/test_pandas_es.py 99.73% <0%> (ø) ⬆️
tests/feature_function_tests/test_agg_feats.py 98.51% <0%> (+0.03%) ⬆️
tests/testing_utils/mock_ds.py 94.59% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8919f2...42a28e8. Read the comment docs.

@kmax12 kmax12 merged commit cbc82d5 into master Jan 18, 2018
@rwedge rwedge mentioned this pull request Jan 18, 2018
@kmax12 kmax12 deleted the median-nan branch January 18, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants