Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run doc tests with make test and on CI #612

merged 5 commits into from Jun 21, 2019

Run doc tests with make test and on CI #612

merged 5 commits into from Jun 21, 2019


Copy link

Currently they are not run by make test, and on CI are not run against python 3.7.

Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #612 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
+ Coverage   97.12%   97.27%   +0.15%     
  Files         118      118              
  Lines        9589     9589              
+ Hits         9313     9328      +15     
+ Misses        276      261      -15
Impacted Files Coverage Δ
featuretools/utils/ 100% <ø> (ø) ⬆️
...aturetools/primitives/standard/ 100% <0%> (+0.34%) ⬆️
featuretools/entityset/ 78.72% <0%> (+2.12%) ⬆️
featuretools/ 50% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e0642...f0e7262. Read the comment docs.

Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CJStadler CJStadler merged commit 177089f into master Jun 21, 2019
@CJStadler CJStadler deleted the run-doc-tests branch June 21, 2019 15:13
@rwedge rwedge mentioned this pull request Jul 3, 2019
johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019
Previously they were not run by make test, and on CI were not
run against python 3.7.

Also, use doctests in Trie.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants