Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #613

merged 4 commits into from Jun 20, 2019

Remove #613

merged 4 commits into from Jun 20, 2019


Copy link

This is not referenced anywhere else.

The commit that added it (99a80d7) seems unrelated, was it added accidentally?

This is not referenced anywhere else, and the commit message (99a80d7)
does not mention it so it may have been added accidentally.
Copy link

kmax12 commented Jun 19, 2019

It's just legacy stuff from the early days. We can remove it now

@kmax12 kmax12 self-requested a review June 19, 2019 21:31
kmax12 previously approved these changes Jun 19, 2019
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #613 into master will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #613      +/-   ##
+ Coverage   96.34%   97.12%   +0.77%     
  Files         119      118       -1     
  Lines        9666     9589      -77     
  Hits         9313     9313              
+ Misses        353      276      -77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2204f0e...1404543. Read the comment docs.

@CJStadler CJStadler merged commit b4e0642 into master Jun 20, 2019
@CJStadler CJStadler deleted the remove-variance-selection branch June 20, 2019 16:13
@rwedge rwedge mentioned this pull request Jul 3, 2019
johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants