Remove variance_selection.py #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not referenced anywhere else, and the commit message (99a80d7) does not mention it so it may have been added accidentally.
|
It's just legacy stuff from the early days. We can remove it now |
kmax12
previously approved these changes
Jun 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 96.34% 97.12% +0.77%
==========================================
Files 119 118 -1
Lines 9666 9589 -77
==========================================
Hits 9313 9313
+ Misses 353 276 -77Continue to review full report at Codecov.
|
…eaturetools into remove-variance-selection
kmax12
approved these changes
Jun 20, 2019
Merged
johnnyheineken
pushed a commit
to johnnyheineken/featuretools
that referenced
this pull request
Jul 7, 2019
This is no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not referenced anywhere else.
The commit that added it (99a80d7) seems unrelated, was it added accidentally?