Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ #620

Merged
merged 32 commits into from Jul 11, 2019
Merged

Add FAQ #620

merged 32 commits into from Jul 11, 2019

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Jun 21, 2019

  • Added a notebook that goes through solutions for FAQs

@gsheni gsheni requested a review from kmax12 June 21, 2019 19:24
@gsheni gsheni changed the title Faq notebook Add FAQ Jun 21, 2019
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #620 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         118      118           
  Lines        9539     9539           
=======================================
  Hits         9293     9293           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c8f506...6c7549e. Read the comment docs.

@gsheni gsheni self-assigned this Jun 23, 2019
@ctduffy
Copy link
Contributor

ctduffy commented Jul 9, 2019

2 comments:

  1. Near code snippet 32/in section "How do I prevent label leakage with DFS":
    What about if the user uses train test split to split the training and testing data? This might be a better example, because there are a few things that must be done to ensure accuracy with this method (ie matching the labels after making the features). I also don't really understand fully how the training and testing data is generated/divided in this example.
    Also, how are categorical variables encoded when splitting training and testing data? What happens if the categorical variable has a value in the testing data but doesn't have it in the training data (this might be an uninformed question)

  2. Below code snippet 64/in section "Why am I getting...?"
    Would it be possible to further clarify the difference between last time index and time index/clarify what it does with the excluded rows? Are these rows used in testing, or how are they factored in (if at all)? Again, not sure how well informed this question is.

These two questions might not be valid questions, in which case they can be ignored.

@gsheni gsheni changed the title Add FAQ Add FAQ, Change CircleCI default python version 3.7.3 Jul 10, 2019
@gsheni gsheni changed the title Add FAQ, Change CircleCI default python version 3.7.3 Add FAQ Jul 10, 2019
docs/source/index.rst Outdated Show resolved Hide resolved
kmax12
kmax12 approved these changes Jul 11, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni gsheni merged commit 7206f7b into master Jul 11, 2019
@gsheni gsheni deleted the faq_notebook branch July 11, 2019 16:17
@rwedge rwedge mentioned this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants