Filter entity df through forward relationship in CFM #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the current entity node uses the full entity df we were filtering the parent using the values from the full df instead of the filtered df. This resulted in calculating features on the full df unnecessarily.
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 118 118
Lines 9532 9532
=======================================
Hits 9287 9287
Misses 245 245
Continue to review full report at Codecov.
|
gsheni
approved these changes
Jun 26, 2019
Merged
johnnyheineken
pushed a commit
to johnnyheineken/featuretools
that referenced
this pull request
Jul 7, 2019
* Filter entity df through forward relationship in CFM If the current entity node uses the full entity df we were filtering the parent using the values from the full df instead of the filtered df. This resulted in calculating features on the full df unnecessarily. * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If the current entity node uses the full entity df we were filtering the
parent using the values from the full df instead of the filtered df.
This resulted in calculating features on the full df unnecessarily.
This bug seems so obvious I'm wondering whether it was just missed
in #598 , or if there is a legitimate reason not to do this through
forward paths which I am now forgetting.