Remove reindex in Entity.query_by_values #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reindex may change the order, and features may assume that the dataframe is ordered by time index. After calculating features reindex to use order of instance_ids.
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
==========================================
+ Coverage 97.42% 97.43% +<.01%
==========================================
Files 118 118
Lines 9532 9543 +11
==========================================
+ Hits 9287 9298 +11
Misses 245 245
Continue to review full report at Codecov.
|
kmax12
suggested changes
Jun 25, 2019
kmax12
previously approved these changes
Jun 25, 2019
CJStadler
commented
Jun 26, 2019
This is faster and doesn't change the type. The function can no longer accept lists, so update the tests to pass in np.ndarray.
…eaturetools into cfm-always-sorted-by-time
kmax12
reviewed
Jun 26, 2019
kmax12
approved these changes
Jun 27, 2019
Merged
johnnyheineken
pushed a commit
to johnnyheineken/featuretools
that referenced
this pull request
Jul 7, 2019
Reindex could change the order, violating the invariant that the dataframe is ordered by time index. After calculating features reindex to use order of instance_ids. FeatureSetCalculator.run can no longer accept lists, so this updates the tests to pass in np.ndarray.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reindexmay change the order of the dataframe, but the dataframeshould keep the existing ordering by time index.
After calculating features call
reindexto order byinstance_ids.