-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed DaysSince primitive #628
removed DaysSince primitive #628
Conversation
I can rebase down to one commit if that is standard practice and desired by the maintainers. Also: thanks for the coffee @kmax12 |
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
- Coverage 97.43% 97.43% -0.01%
==========================================
Files 118 118
Lines 9543 9534 -9
==========================================
- Hits 9298 9289 -9
Misses 245 245
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the contribution @kkleidal. You can squash when you merge.
Thanks @CJStadler . To which branch do you mean I should merge? |
Sorry @kkleidal, I didn't realize you couldn't merge to master. Thanks again! |
Since it is made obsolete by TimeSince. Fixes alteryx#605
Pull Request Description
Fixes #605
According to #605 , DaysSince is made obsolete by TimeSince, since DaysSince is equivalent to TimeSince(unit="days"). This patch removes the obsolete DaysSince primitive
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rst
to include this pull request.