Skip to content

Add cumulative primitives to docs #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Add cumulative primitives to docs #632

merged 3 commits into from
Jul 3, 2019

Conversation

CJStadler
Copy link
Contributor

These seem to be missing.

@@ -156,6 +156,11 @@ Cumulative Transform Primitives

Diff
TimeSincePrevious
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the above two belong under "Cumulative Transform Primitives"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the best place to put them for now since they do use multiple rows of the dataframe, although in this case just the previous

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #632 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #632   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         118      118           
  Lines        9535     9535           
=======================================
  Hits         9290     9290           
  Misses        245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7203f2d...25d03d1. Read the comment docs.

@@ -156,6 +156,11 @@ Cumulative Transform Primitives

Diff
TimeSincePrevious
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the best place to put them for now since they do use multiple rows of the dataframe, although in this case just the previous

@CJStadler CJStadler merged commit e67fe58 into master Jul 3, 2019
@CJStadler CJStadler deleted the cumulative-docs branch July 3, 2019 16:32
@rwedge rwedge mentioned this pull request Jul 3, 2019
johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants