Add cumulative primitives to docs #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJStadler
commented
Jul 1, 2019
| @@ -156,6 +156,11 @@ Cumulative Transform Primitives | |||
|
|
|||
| Diff | |||
| TimeSincePrevious | |||
There was a problem hiding this comment.
Do the above two belong under "Cumulative Transform Primitives"?
There was a problem hiding this comment.
that's the best place to put them for now since they do use multiple rows of the dataframe, although in this case just the previous
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 118 118
Lines 9535 9535
=======================================
Hits 9290 9290
Misses 245 245Continue to review full report at Codecov.
|
kmax12
approved these changes
Jul 3, 2019
| @@ -156,6 +156,11 @@ Cumulative Transform Primitives | |||
|
|
|||
| Diff | |||
| TimeSincePrevious | |||
There was a problem hiding this comment.
that's the best place to put them for now since they do use multiple rows of the dataframe, although in this case just the previous
Merged
johnnyheineken
pushed a commit
to johnnyheineken/featuretools
that referenced
this pull request
Jul 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
These seem to be missing.