Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved dask, distributed imports #634

Merged
merged 13 commits into from
Jul 8, 2019
Merged

Moved dask, distributed imports #634

merged 13 commits into from
Jul 8, 2019

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jul 1, 2019 •
edited
Loading

  • Moved dask, distributed imports so they are inside the function. This is because dask/distributed is an optional library for featuretools

@gsheni gsheni requested review from kmax12 and rwedge July 1, 2019 22:15
@gsheni gsheni self-assigned this Jul 1, 2019
@gsheni gsheni changed the title Fix dask imports Moved dask, distributed imports Jul 2, 2019
@codecov
Copy link

codecov bot commented Jul 2, 2019 •
edited
Loading

Codecov Report

Merging #634 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
+ Coverage   97.43%   97.43%   +<.01%     
==========================================
  Files         118      118              
  Lines        9535     9538       +3     
==========================================
+ Hits         9290     9293       +3     
  Misses        245      245
Impacted Files Coverage Δ
featuretools/computational_backends/utils.py 95.83% <100%> (+0.07%) ⬆️
featuretools/tests/testing_utils/__init__.py 100% <100%> (ø) ⬆️
featuretools/tests/testing_utils/cluster.py 100% <100%> (ø) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.35% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d4b22...433a3b2. Read the comment docs.

rwedge
rwedge previously requested changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move dask and distributed from requirements.txt to test-requirements.txt since they are now optional

@gsheni
Copy link
Contributor Author

gsheni commented Jul 3, 2019 •
edited
Loading

Can we move dask and distributed from requirements.txt to test-requirements.txt since they are now optional

Let's keep it in requirements.txt so that if users run DFS with n_jobs > 1, it won't give an error.

kmax12
kmax12 suggested changes Jul 7, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments. otherwise looks good to me

@gsheni gsheni requested review from kmax12 and rwedge July 8, 2019 01:09
@gsheni gsheni removed the request for review from rwedge July 8, 2019 13:49
@gsheni gsheni merged commit a990858 into master Jul 8, 2019
@gsheni gsheni deleted the fix_dask_imports branch July 8, 2019 13:50
@rwedge rwedge mentioned this pull request Aug 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge left review comments

@kmax12 kmax12 kmax12 approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsheni @kmax12 @rwedge