Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation about multi output features #638

Merged
merged 9 commits into from
Jul 9, 2019

Conversation

ctduffy
Copy link
Contributor

@ctduffy ctduffy commented Jul 3, 2019

This PR updates the documentation for multi output features.

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         118      118           
  Lines        9539     9539           
=======================================
  Hits         9293     9293           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4c5ca...540ed99. Read the comment docs.

@ctduffy ctduffy requested a review from rwedge July 3, 2019 20:25
@ctduffy ctduffy requested a review from kmax12 July 8, 2019 20:08
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to merge

number_output_features=2)


Passing in ``string="test"`` as a keyword argument when initializing the `StringCount` primitive will make "test" the value used for string when ``string_count`` is called to calculate the feature values. Now we use this primitive to define features and calculate the feature values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this paragraph was accidently copied

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an outdated version and no longer exists in the most recent commits. not sure why it still appears here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was my mistake. i had forgot to refresh from a while ago

@ctduffy ctduffy merged commit 5ffbe9e into master Jul 9, 2019
@ctduffy ctduffy deleted the multi-putput-doc-update branch July 9, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants