Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.4 support #64

Merged
merged 6 commits into from Jan 12, 2018
Merged

Remove Python 3.4 support #64

merged 6 commits into from Jan 12, 2018

Conversation

bschreck
Copy link
Contributor

Pandas does not support Python 3.4, and it causes problems for out CI validation, so we should not support it.

@codecov-io
Copy link

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   87.36%   87.36%           
=======================================
  Files          74       74           
  Lines        6986     6986           
=======================================
  Hits         6103     6103           
  Misses        883      883

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec9593d...a2a3984. Read the comment docs.

requirements.txt Outdated
scipy>=1.0.0
pandas==0.20.3
pandas>=0.22.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can relax this a bit. any reason not to do pandas>=0.20.3?

@bschreck
Copy link
Contributor Author

Assuming this makes it into the next release: D3M’s next release is using 0.22, so it would be nice to have a released version that is compatible with it

@kmax12
Copy link
Contributor

kmax12 commented Jan 12, 2018

if we use >=0.20.3, we'd be fine with pandas 0.22, right?

@bschreck
Copy link
Contributor Author

hmm yeah my thought was skipping the bad 0.21 version of pandas, but I think it's fine

@kmax12 kmax12 merged commit 5bb8864 into master Jan 12, 2018
@rwedge rwedge mentioned this pull request Jan 18, 2018
@kmax12 kmax12 deleted the remove-python-3.4-support branch January 18, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants