Remove Python 3.4 support #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 74 74
Lines 6986 6986
=======================================
Hits 6103 6103
Misses 883 883Continue to review full report at Codecov.
|
kmax12
reviewed
Jan 12, 2018
requirements.txt
Outdated
| scipy>=1.0.0 | ||
| pandas==0.20.3 | ||
| pandas>=0.22.0 |
There was a problem hiding this comment.
i think we can relax this a bit. any reason not to do pandas>=0.20.3?
|
Assuming this makes it into the next release: D3M’s next release is using 0.22, so it would be nice to have a released version that is compatible with it |
|
if we use |
|
hmm yeah my thought was skipping the bad 0.21 version of pandas, but I think it's fine |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas does not support Python 3.4, and it causes problems for out CI validation, so we should not support it.