New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.4 support #64
Conversation
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 74 74
Lines 6986 6986
=======================================
Hits 6103 6103
Misses 883 883 Continue to review full report at Codecov.
|
requirements.txt
Outdated
scipy>=1.0.0 | ||
pandas==0.20.3 | ||
pandas>=0.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can relax this a bit. any reason not to do pandas>=0.20.3
?
Assuming this makes it into the next release: D3M’s next release is using 0.22, so it would be nice to have a released version that is compatible with it |
if we use |
hmm yeah my thought was skipping the bad 0.21 version of pandas, but I think it's fine |
Pandas does not support Python 3.4, and it causes problems for out CI validation, so we should not support it.