Skip to content

Conversation

@rwedge
Copy link
Contributor

@rwedge rwedge commented Jul 3, 2019

Pull Request Description

New Future Release section for next development cycle


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         118      118           
  Lines        9535     9535           
=======================================
  Hits         9290     9290           
  Misses        245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7adfde...e4ba086. Read the comment docs.

@rwedge rwedge requested review from gsheni and kmax12 July 3, 2019 21:34
* Documentation Changes
* Miscellaneous changes (:pr:`641`)
* Testing Changes
* Miscellaneous changes ()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No PR number?

Copy link
Contributor Author

@rwedge rwedge Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the Miscellaneous there since normal testing changes should be recorded there

If we don't have any this dev cycle I'll remove it in the release PR

Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good besides the 1 question

@rwedge rwedge merged commit 32d4b22 into master Jul 3, 2019
@rwedge rwedge deleted the future-release-changelog-0-9-1 branch July 3, 2019 21:45
johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019
* Add new Future Release section to changelog

* update changelog

* add self as contributor
@rwedge rwedge mentioned this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants