Move exporting feature matrix example in docs #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 118 118
Lines 9560 9560
=======================================
Hits 9314 9314
Misses 246 246Continue to review full report at Codecov.
|
gsheni
previously approved these changes
Jul 11, 2019
gsheni
previously approved these changes
Jul 11, 2019
docs/source/changelog.rst
Outdated
| @@ -9,7 +9,7 @@ Changelog | |||
| * Changes | |||
| * Moved dask, distributed imports (:pr:`634`) | |||
| * Documentation Changes | |||
| * Miscellaneous changes (:pr:`641`) | |||
| * Miscellaneous changes (:pr:`641`, :pr:`658`) | |||
| * Modified doc_string of top_n in encoding (:pr:`648`) | |||
| * Hyperlinked ComposeML (:pr:`653`) | |||
| * Testing Changes | |||
There was a problem hiding this comment.
Missing user name 4 lines below
…Featuretools/featuretools into remove-exporting-feature-matrix
kmax12
changed the title
|
Can you add yourself to the list of contributors? |
rwedge
reviewed
Jul 11, 2019
docs/source/guides/deployment.rst
Outdated
| @@ -68,3 +68,29 @@ After we load the features back in, we can calculate the feature matrix. | |||
| As you can see above, we have the exact same features as before, but calculated on using our test data. | |||
There was a problem hiding this comment.
"calculated on using our test data" sounds awkward
rwedge
approved these changes
Jul 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't need to be at the top level of the documentation and fits well within the deployment page