New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move exporting feature matrix example in docs #658
Conversation
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 118 118
Lines 9560 9560
=======================================
Hits 9314 9314
Misses 246 246 Continue to review full report at Codecov.
|
docs/source/changelog.rst
Outdated
@@ -9,7 +9,7 @@ Changelog | |||
* Changes | |||
* Moved dask, distributed imports (:pr:`634`) | |||
* Documentation Changes | |||
* Miscellaneous changes (:pr:`641`) | |||
* Miscellaneous changes (:pr:`641`, :pr:`658`) | |||
* Modified doc_string of top_n in encoding (:pr:`648`) | |||
* Hyperlinked ComposeML (:pr:`653`) | |||
* Testing Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing user name 4 lines below
…Featuretools/featuretools into remove-exporting-feature-matrix
Can you add yourself to the list of contributors? |
docs/source/guides/deployment.rst
Outdated
@@ -68,3 +68,29 @@ After we load the features back in, we can calculate the feature matrix. | |||
As you can see above, we have the exact same features as before, but calculated on using our test data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"calculated on using our test data" sounds awkward
Doesn't need to be at the top level of the documentation and fits well within the deployment page