Skip to content

Add Trigger Test #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 11, 2019
Merged

Add Trigger Test #660

merged 12 commits into from
Jul 11, 2019

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jul 11, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2019 •
edited
Loading

Codecov Report

Merging #660 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         118      118           
  Lines        9539     9539           
=======================================
  Hits         9293     9293           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7206f7b...9dd5e52. Read the comment docs.

@gsheni gsheni self-assigned this Jul 11, 2019
@gsheni gsheni requested review from rwedge and kmax12 and removed request for rwedge July 11, 2019 17:11
kmax12
kmax12 previously approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me. although will defer to @rwedge since he know circleci better than i do

rwedge
rwedge reviewed Jul 11, 2019
View reviewed changes
rwedge
rwedge approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit a3966fa into master Jul 11, 2019
@gsheni gsheni deleted the add_pp_test branch July 11, 2019 19:20
@rwedge rwedge mentioned this pull request Aug 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

@kmax12 kmax12 kmax12 left review comments

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsheni @kmax12 @rwedge