Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed FAQ question with multiple question marks #673

Merged
merged 3 commits into from Jul 16, 2019
Merged

Fixed FAQ question with multiple question marks #673

merged 3 commits into from Jul 16, 2019

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Jul 16, 2019

  • Fixed FAQ question with multiple question marks
  • added calculate_feature_matrix call to better represent workflow

@gsheni gsheni requested a review from kmax12 July 16, 2019 14:35
@gsheni gsheni self-assigned this Jul 16, 2019
@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         118      118           
  Lines        9560     9560           
=======================================
  Hits         9314     9314           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a45034...674dd5a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 16, 2019 •
edited

Codecov Report

Merging #673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         118      118           
  Lines        9560     9560           
=======================================
  Hits         9314     9314           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a45034...674dd5a. Read the comment docs.

kmax12
kmax12 approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni gsheni merged commit ded4809 into master Jul 16, 2019
@gsheni gsheni deleted the faq_update branch July 16, 2019 16:46
@rwedge rwedge mentioned this pull request Aug 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmax12 kmax12 kmax12 approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsheni @kmax12