Conversation
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
- Coverage 97.77% 97.76% -0.02%
==========================================
Files 119 119
Lines 10870 10861 -9
==========================================
- Hits 10628 10618 -10
- Misses 242 243 +1
Continue to review full report at Codecov.
|
kmax12
changed the title
rwedge
reviewed
Sep 25, 2019
| assert old_es_2.__eq__(es_2, deep=True) | ||
|
|
||
| assert es_3.__eq__(es, deep=True) | ||
| assert es_3.__eq__(es) |
Contributor
There was a problem hiding this comment.
If this is due to no longer sorting data for entities without time indexes, we could potentially not split up the data of non-time entities and then we could still do a deep comparison
Contributor
Author
There was a problem hiding this comment.
below, we check for the fact that the dataframes have the same data after concatenation, so I think it's fine to just remove the deep check here and not mess with the test
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
ft.calculate_feature_matrixto return rows in the order of the instance ids provided.It also updates entity loading to only sort the input dataframe if a
time_indexis present. This ensures rows will be returned in the same order as the input if no time index is provided and no instance ids are provided