Normalize entity same index as base entity #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyliweishih
changed the title
|
|
rwedge
reviewed
Jul 22, 2019
docs/source/changelog.rst
Outdated
| @@ -11,6 +11,7 @@ Changelog | |||
| * Set index after adding ancestor relationship variables (:pr:`668`) | |||
| * Fix user-supplied variable_types modification in Entity init (:pr:`675`) | |||
| * Don't calculate dependencies of unnecessary features (:pr:`667`) | |||
| * Normalize entity same index as base entity #681 (:pr:`681`) | |||
There was a problem hiding this comment.
The ":pr:681" syntax will create a link to this pr, you can remove the "#681". Also can you add a little more to the description so someone unfamiliar could grasp the issue?
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 97.44% 97.44% +<.01%
==========================================
Files 118 118
Lines 9634 9643 +9
==========================================
+ Hits 9388 9397 +9
Misses 246 246
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request addresses #670 .
Adds a check and raises an exception if the index of the base entity is equal to the index argument. This request adds an accompanying test case.
As stated in #670, Feature tools does not handle one-to-one relationships in entitysets. Therefore, this check must be made to stop creating a one-to-one relationship with the same index.