Update variable type inference to better check for string values #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmax12
changed the title
kmax12
commented
Jul 23, 2019
| @@ -39,20 +39,28 @@ def infer_variable_types(df, link_vars, variable_types, time_index, secondary_ti | |||
| else: | |||
| inferred_type = vtypes.Numeric | |||
|
|
|||
| elif variable in link_vars: | |||
| inferred_type = vtypes.Categorical | |||
There was a problem hiding this comment.
link_vars should be categorical, not ordinal.
kmax12
commented
Jul 23, 2019
| # heuristics to predict this some other than categorical | ||
| sample = df[variable].sample(min(10000, len(df[variable]))) | ||
|
|
||
| # catch cases where object dtype cannot be interpreted as a string |
There was a problem hiding this comment.
this is the core of the fix
kmax12
commented
Jul 23, 2019
| return False | ||
| else: | ||
| return True | ||
| # if it can be casted to numeric, it's not a datetime |
There was a problem hiding this comment.
addressed the todo, to specifically throw away datetimes that are numeric
kmax12
commented
Jul 23, 2019
featuretools/utils/entity_utils.py
Outdated
| # finally, try to cast to datetime | ||
| if col.dtype.name.find('str') > -1 or col.dtype.name.find('object') > -1: | ||
| try: | ||
| pd.to_datetime(col.dropna(), errors='raise') |
There was a problem hiding this comment.
updated to just check all columns
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
==========================================
+ Coverage 97.44% 97.47% +0.02%
==========================================
Files 118 118
Lines 9643 9670 +27
==========================================
+ Hits 9397 9426 +29
+ Misses 246 244 -2
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes a small issue that came up in pandas 0.25.0 testing.
While fixing, also did a small refactor to how we infer variable types