Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding autonormalize to extras_require #699

Merged
merged 14 commits into from Aug 16, 2019
Merged

Conversation

allisonportis
Copy link
Contributor

adding autonormalize to extras_require in setup.py


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@56048d2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #699   +/-   ##
=========================================
  Coverage          ?   97.51%           
=========================================
  Files             ?      118           
  Lines             ?    10035           
  Branches          ?        0           
=========================================
  Hits              ?     9786           
  Misses            ?      249           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56048d2...0987b9c. Read the comment docs.

@kmax12
Copy link
Contributor

kmax12 commented Aug 6, 2019

let's also make sure to test it gets installed correctly. see here for example

https://github.com/Featuretools/featuretools/blob/master/.circleci/config.yml#L159

docs/source/changelog.rst Outdated Show resolved Hide resolved
kmax12
kmax12 previously approved these changes Aug 16, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allisonportis allisonportis merged commit d904f7b into master Aug 16, 2019
@allisonportis allisonportis deleted the autonormalize_entrypoint branch August 16, 2019 18:58
@rwedge rwedge mentioned this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants