-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package linting #7
Conversation
298bf5f
to
9996438
Compare
Thanks @joshblum. For the linting, let's turn off the 80 character limit check. For now, we will leave it to the developer to decide if going over 80 characters will increase the readability of the code. For example, in your changes to |
featuretools/__init__.py
Outdated
from . import tests | ||
from .utils.pickle_utils import * | ||
import featuretools.demo | ||
import config # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you can put # flake8: noqa
at the top of the file rather than repeat on every line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good!
3ca99f1
to
236be37
Compare
f747293
to
4b2f726
Compare
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
- Coverage 86.86% 86.83% -0.04%
==========================================
Files 73 73
Lines 6778 6768 -10
==========================================
- Hits 5888 5877 -11
- Misses 890 891 +1
Continue to review full report at Codecov.
|
4b2f726
to
8fb1d26
Compare
8fb1d26
to
7c422d6
Compare
Depends on #6 (once that is merged I'll rebase this so it cleanly reflects only the lint changes). @kmax12 there are a lot of changes to make to make the project pass
flake8
.I cleaned the file
featuretools/computational_backends/calculate_feature_matrix.py
as an example. Let me know if you want me to proceed with adding linting to the build (and getting the other files to pass). If you have any preference for the flake8 config let me know before I continue.