Last time index fixes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
+ Coverage 87.36% 87.6% +0.24%
=========================================
Files 74 75 +1
Lines 6986 7131 +145
=========================================
+ Hits 6103 6247 +144
- Misses 883 884 +1
Continue to review full report at Codecov.
|
kmax12
reviewed
Jan 18, 2018
featuretools/entityset/entityset.py
Outdated
| if entity.has_time_index(): | ||
| entity.set_last_time_index(entity.df[entity.time_index]) | ||
| else: | ||
| lti = copy.deepcopy(entity.df[entity.time_index]) |
There was a problem hiding this comment.
any reason you can't just use entity.df[entity.time_index].copy()?
featuretools/entityset/entityset.py
Outdated
| else: | ||
| lti = copy.deepcopy(entity.df[entity.index]) | ||
| lti[:] = None | ||
| lti = pd.to_datetime(lti) |
There was a problem hiding this comment.
did we require lti to be a datetime before? why do we need to convert it here?
|
Looks good to me! BTW, great job writing tests for this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes addressing several issues when calculating
last_time_index:last_time_indexinstance values taken from one child entity if that parent instance was not present in another child entitylast_time_indexif the entity had multiple generations of child entities