Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding categorical-encoding to #700

merged 9 commits into from Aug 16, 2019


Copy link

Pull Request Description

Incorporating categorical-encoding PyPi library release into Featuretools.

Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #700   +/-   ##
  Coverage   97.64%   97.64%           
  Files         118      118           
  Lines       10173    10173           
  Hits         9933     9933           
  Misses        240      240

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bf7210...b7a87b4. Read the comment docs.

@kmax12 kmax12 self-requested a review August 7, 2019 22:46
kmax12 previously approved these changes Aug 7, 2019
Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looks good, but let's hold off on merging for now.

Copy link

kmax12 commented Aug 14, 2019

@alexjwang can you also add to docs/source/getting_started/install.rst? look at how we do it in #699

@alexjwang alexjwang merged commit 89c242f into master Aug 16, 2019
@alexjwang alexjwang deleted the categorical-encoding-library branch August 16, 2019 21:13
@rwedge rwedge mentioned this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants