Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAQ cell output #710

merged 6 commits into from Aug 25, 2019

Fix FAQ cell output #710

merged 6 commits into from Aug 25, 2019


Copy link

@gsheni gsheni commented Aug 20, 2019

  • FAQ notebook had a cell that was run
    • The FAQ notebook + sphinx docs needs to have no output when committed. The sphinx docs will run all the cells in the notebook when it builds the docs. But the cells for FAQ notebook won't be run if 1 or more cells has previously ran (with a saved output in the notebook).

Copy link

codecov bot commented Aug 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4bcb4ad). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #710   +/-   ##
  Coverage          ?   97.63%           
  Files             ?      118           
  Lines             ?    10177           
  Branches          ?        0           
  Hits              ?     9936           
  Misses            ?      241           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bcb4ad...4c8c11b. Read the comment docs.

@gsheni gsheni self-assigned this Aug 23, 2019
@gsheni gsheni requested a review from kmax12 August 23, 2019 04:45
Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging

@kmax12 kmax12 merged commit e9b7f62 into master Aug 25, 2019
@kmax12 kmax12 deleted the fix_faq branch August 25, 2019 17:40
@rwedge rwedge mentioned this pull request Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants