Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete the whole destination folder while saving entityset #717

Merged
merged 7 commits into from Sep 13, 2019

Conversation

chidauri
Copy link
Contributor

Pull Request Description

Fixes #706 as the title suggests. The new functionality is to replace the conflicting files only and not the whole path.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #717 into master will decrease coverage by 0.02%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   97.66%   97.64%   -0.03%     
==========================================
  Files         118      118              
  Lines       10289    10301      +12     
==========================================
+ Hits        10049    10058       +9     
- Misses        240      243       +3
Impacted Files Coverage Δ
...etools/tests/entityset_tests/test_serialization.py 98.08% <100%> (+0.09%) ⬆️
featuretools/entityset/serialize.py 95.12% <50%> (-3.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6873c...c738a87. Read the comment docs.

@rwedge
Copy link
Contributor

rwedge commented Sep 9, 2019

Thanks again, @chidauri. Could you add a test case confirming that this no longer deletes unrelated files in the destination folder?

@@ -268,6 +268,13 @@ def test_serialize_url_csv(es):
es.to_csv(URL, encoding='utf-8', engine='python')


def test_serialize_data_description(es, tmpdir):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test name could be updated to provide more context about that it is testing extra files are not removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's an issue with py35 / py27 tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

@rwedge
Copy link
Contributor

rwedge commented Sep 11, 2019

@chidauri thanks for adding the test case! I think it would also be good to test that old serialization files (e.g. data_description.json) get overwritten.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rwedge rwedge merged commit ce4558b into alteryx:master Sep 13, 2019
@rwedge rwedge mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving entityset deletes whole destination folder
3 participants