Don't delete the whole destination folder while saving entityset #717
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
- Coverage 97.66% 97.64% -0.03%
==========================================
Files 118 118
Lines 10289 10301 +12
==========================================
+ Hits 10049 10058 +9
- Misses 240 243 +3
Continue to review full report at Codecov.
|
|
Thanks again, @chidauri. Could you add a test case confirming that this no longer deletes unrelated files in the destination folder? |
| @@ -268,6 +268,13 @@ def test_serialize_url_csv(es): | |||
| es.to_csv(URL, encoding='utf-8', engine='python') | |||
|
|
|||
|
|
|||
| def test_serialize_data_description(es, tmpdir): | |||
There was a problem hiding this comment.
this test name could be updated to provide more context about that it is testing extra files are not removed
There was a problem hiding this comment.
Looks like there's an issue with py35 / py27 tests.
|
@chidauri thanks for adding the test case! I think it would also be good to test that old serialization files (e.g. data_description.json) get overwritten. |
Pull Request Description
Fixes #706 as the title suggests. The new functionality is to replace the conflicting files only and not the whole path.
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request.