Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how files are copied and written #721

Merged
merged 4 commits into from Sep 3, 2019
Merged

Improve how files are copied and written #721

merged 4 commits into from Sep 3, 2019

Conversation

kmax12
Copy link
Contributor

@kmax12 kmax12 commented Aug 30, 2019

No need to iterate line by line when there are more optimized method. This PR uses them

@kmax12 kmax12 requested a review from rwedge August 30, 2019 01:14
@kmax12 kmax12 changed the title Improve how copies are copied and written Improve how files are copied and written Aug 30, 2019
@codecov
Copy link

codecov bot commented Aug 30, 2019 •
edited

Codecov Report

Merging #721 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
- Coverage   97.63%   97.63%   -0.01%     
==========================================
  Files         118      118              
  Lines       10201    10194       -7     
==========================================
- Hits         9960     9953       -7     
  Misses        241      241
Impacted Files Coverage Δ
featuretools/utils/gen_utils.py 93.4% <100%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3195659...f33e823. Read the comment docs.

rwedge
rwedge approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kmax12 kmax12 merged commit 7d9da15 into master Sep 3, 2019
@rwedge rwedge deleted the improve-file-copy-write branch September 6, 2019 17:02
@kmax12 kmax12 restored the improve-file-copy-write branch September 11, 2019 15:18
@kmax12 kmax12 deleted the improve-file-copy-write branch September 11, 2019 15:20
@rwedge rwedge mentioned this pull request Sep 30, 2019
Merged
@rwedge rwedge restored the improve-file-copy-write branch October 16, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmax12 @rwedge