New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add number of rows to plot of entityset #727
Add number of rows to plot of entityset #727
Conversation
Would you be willing to add a test case that checks the number of rows reported in the graph and checks the single row edge case? |
Sure - will do! |
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
+ Coverage 97.63% 97.64% +<.01%
==========================================
Files 118 118
Lines 10205 10222 +17
==========================================
+ Hits 9964 9981 +17
Misses 241 241
Continue to review full report at Codecov.
|
@rwedge How should graphviz output be tested? I've tried with a regular expression, please let me know if there's a better way / you'd like this done differently |
@MarcoGorelli the tests look good, thanks! Could you add yourself the list of contributors for the upcoming release in the changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the contribution!
Happy to help, thank you for your tool! |
Pull Request Description
Add number of rows to graph of entityset, closes #722
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rst
to include this pull request.