Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated training window error assertion for relative units #728

Merged
merged 10 commits into from Sep 6, 2019

Conversation

christopherbunn
Copy link
Contributor

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3951bfe). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #728   +/-   ##
=========================================
  Coverage          ?   97.64%           
=========================================
  Files             ?      118           
  Lines             ?    10247           
  Branches          ?        0           
=========================================
  Hits              ?    10006           
  Misses            ?      241           
  Partials          ?        0
Impacted Files Coverage Δ
featuretools/synthesis/dfs.py 100% <ø> (ø)
featuretools/entityset/entity.py 96.09% <100%> (ø)
...utational_backend/test_calculate_feature_matrix.py 99.35% <100%> (ø)
featuretools/tests/synthesis/test_dfs_method.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3951bfe...b6bb5e6. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What do you think @rwedge?

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add testing for edge cases like leap years? Otherwise LGTM!

jeremyliweishih
jeremyliweishih previously approved these changes Sep 5, 2019
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @rwedge

assert feature_matrix_2.index.all([1, 2, 3, 4])
assert feature_matrix_3.index.all([2, 3, 4])
assert feature_matrix_4.index.all([2, 3, 4])
assert feature_matrix_4.index.all([2, 3])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these assertions are working as intended. assert feature_matrix_4.index.all([2, 3, 4]) and assert feature_matrix_4.index.all([2, 3]) are both evaluating as True

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@christopherbunn christopherbunn merged commit 1de047b into master Sep 6, 2019
@kmax12 kmax12 deleted the dfs-training-window branch September 11, 2019 15:20
@rwedge rwedge mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants