Added support for pd.DateOffset in DFS#732
Merged
christopherbunn merged 34 commits intomasterfrom Sep 25, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
=========================================
Coverage ? 97.68%
=========================================
Files ? 118
Lines ? 10543
Branches ? 0
=========================================
Hits ? 10299
Misses ? 244
Partials ? 0
Continue to review full report at Codecov.
|
jeremyliweishih
requested changes
Sep 9, 2019
Contributor
jeremyliweishih
left a comment
jeremyliweishih
left a comment
There was a problem hiding this comment.
Looks good so far and left some comments!
jeremyliweishih
requested changes
Sep 9, 2019
…et to Timedelta tests
…rom weeks to days
…ols into dfs-pd-dateoffset
jeremyliweishih
requested changes
Sep 12, 2019
jeremyliweishih
requested changes
Sep 16, 2019
This was referenced Sep 16, 2019
rwedge
reviewed
Sep 25, 2019
| _readable_to_unit = {v.lower(): k for k, v in _readable_units.items()} | ||
|
|
||
| def __init__(self, value, unit=None): | ||
| def __init__(self, value, unit=None, delta_obj=None): |
Contributor
There was a problem hiding this comment.
Should we document the delta_obj parameter?
Contributor
Author
There was a problem hiding this comment.
I think we should so it's clear that it's more for _check_timedelta() and it's not necessary if a user only wants to use value and units to instantiate.
…documentation for delta_obj
…ols into dfs-pd-dateoffset
rwedge
approved these changes
Sep 25, 2019
jeremyliweishih
approved these changes
Sep 25, 2019
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for pd.DateOffset in DFS parameters (#729)