Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cum count fix #733

merged 20 commits into from Sep 11, 2019

Cum count fix #733

merged 20 commits into from Sep 11, 2019


Copy link

Pull Request Description

Fixes #607 by changing handling of groupby_trans_primitives that take ID as input

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

Copy link

CLAassistant commented Sep 9, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #733 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
+ Coverage   97.65%   97.66%   +0.01%     
  Files         118      118              
  Lines       10279    10289      +10     
+ Hits        10038    10049      +11     
+ Misses        241      240       -1
Impacted Files Coverage Δ
featuretools/synthesis/ 96.34% <100%> (+0.27%) ⬆️
...ols/tests/synthesis/ 98.7% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc7856...bbadfba. Read the comment docs.

@frances-h frances-h self-assigned this Sep 9, 2019
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frances-h frances-h merged commit 3aa9981 into master Sep 11, 2019
@frances-h frances-h deleted the cum-count-fix branch September 11, 2019 17:46
@rwedge rwedge mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

CumCount doesn't get applied
3 participants