Adding support for feature-specific top_n in encode_features #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@angela97lin can you merge the latest master into your branch and resolve the conflicts? |
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
+ Coverage 97.64% 97.65% +<.01%
==========================================
Files 118 118
Lines 10249 10279 +30
==========================================
+ Hits 10008 10038 +30
Misses 241 241
Continue to review full report at Codecov.
|
rwedge
reviewed
Sep 10, 2019
rwedge
reviewed
Sep 10, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for passing in dictionary as top_n for feature-specific top_n in encode_features (#505)