Skip to content

Adding support for feature-specific top_n in encode_features#735

Merged
angela97lin merged 6 commits into
masterfrom
different_top_n
Sep 10, 2019
Merged

Adding support for feature-specific top_n in encode_features#735
angela97lin merged 6 commits into
masterfrom
different_top_n

Conversation

@angela97lin

Copy link
Copy Markdown
Contributor

Adding support for passing in dictionary as top_n for feature-specific top_n in encode_features (#505)

@angela97lin angela97lin requested a review from rwedge September 10, 2019 16:08
@CLAassistant

CLAassistant commented Sep 10, 2019

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@rwedge

rwedge commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

@angela97lin can you merge the latest master into your branch and resolve the conflicts?

@codecov

codecov Bot commented Sep 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #735 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   97.64%   97.65%   +<.01%     
==========================================
  Files         118      118              
  Lines       10249    10279      +30     
==========================================
+ Hits        10008    10038      +30     
  Misses        241      241
Impacted Files Coverage Δ
featuretools/synthesis/encode_features.py 98.5% <100%> (+0.06%) ⬆️
...aturetools/tests/synthesis/test_encode_features.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac826ea...11e2ef2. Read the comment docs.

Comment thread featuretools/synthesis/encode_features.py Outdated
Comment thread featuretools/tests/synthesis/test_encode_features.py
Comment thread featuretools/tests/synthesis/test_encode_features.py Outdated
Comment thread featuretools/synthesis/encode_features.py Outdated
Comment thread featuretools/tests/synthesis/test_encode_features.py Outdated
Comment thread featuretools/synthesis/encode_features.py Outdated

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@angela97lin angela97lin merged commit 1bc7856 into master Sep 10, 2019
@angela97lin angela97lin deleted the different_top_n branch September 10, 2019 22:48
@rwedge rwedge mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants