Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mock dependency #738

merged 3 commits into from Sep 12, 2019

Remove mock dependency #738

merged 3 commits into from Sep 12, 2019


Copy link

@rwedge rwedge commented Sep 11, 2019

This PR removes mock as a dependency to run the tests. Featuretools doesn't import mock directly. Another testing dependency, moto, also has mock as a dependency, so mock will still be installed in order to run the tests.

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

Copy link

codecov bot commented Sep 11, 2019

Codecov Report

No coverage uploaded for pull request base (master@3aa9981). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #738   +/-   ##
  Coverage          ?   97.66%           
  Files             ?      118           
  Lines             ?    10289           
  Branches          ?        0           
  Hits              ?    10049           
  Misses            ?      240           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aa9981...8e12aa5. Read the comment docs.

@rwedge rwedge requested a review from kmax12 September 11, 2019 21:21
@rwedge rwedge merged commit 5b6873c into master Sep 12, 2019
@rwedge rwedge deleted the remove_mock branch September 12, 2019 13:58
@rwedge rwedge mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants