Repository navigation
Adding progress_callback parameter to dfs() and calculate_feature_matrix(), removing time remaining - #739
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 97.66% 97.69% +0.03%
==========================================
Files 118 118
Lines 10289 10340 +51
==========================================
+ Hits 10049 10102 +53
+ Misses 240 238 -2
Continue to review full report at Codecov.
|
kmax12
suggested changes
Sep 13, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #705 and #736 by adding
progress_callbackparameter todfs()andcalculate_feature_matrix() and removing time remaining field from the progress bar inverbose=Truemode.