Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding progress_callback parameter to dfs() and calculate_feature_matrix(), removing time remaining #739

merged 14 commits into from Sep 16, 2019


Copy link

Addresses #705 and #736 by adding progress_callback parameter to dfs() and calculate_feature_matrix() and removing time remaining field from the progress bar in verbose=True mode.

Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #739 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #739      +/-   ##
+ Coverage   97.66%   97.69%   +0.03%     
  Files         118      118              
  Lines       10289    10340      +51     
+ Hits        10049    10102      +53     
+ Misses        240      238       -2
Impacted Files Coverage Δ
...s/computational_backends/ 98.23% <ø> (ø) ⬆️
featuretools/synthesis/ 100% <ø> (ø) ⬆️
featuretools/tests/synthesis/ 100% <100%> (ø) ⬆️
...computational_backends/ 98.93% <100%> (+0.79%) ⬆️
...utational_backend/ 99.37% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6873c...5af16dd. Read the comment docs.

Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Go ahead and merge

@angela97lin angela97lin merged commit 8b7a2e6 into master Sep 16, 2019
@angela97lin angela97lin deleted the progress_callback branch September 16, 2019 18:33
@rwedge rwedge mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants