add ability to specify primitives per entity or variable#748
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
==========================================
+ Coverage 97.69% 97.77% +0.08%
==========================================
Files 118 119 +1
Lines 10576 10870 +294
==========================================
+ Hits 10332 10628 +296
+ Misses 244 242 -2
Continue to review full report at Codecov.
|
frances-h
changed the title
frances-h
changed the title
rwedge
suggested changes
Sep 24, 2019
kmax12
suggested changes
Sep 26, 2019
kmax12
left a comment
kmax12
left a comment
Contributor
There was a problem hiding this comment.
looking good overall. Mainly added some comments about presentation in the documentation.
kmax12
previously approved these changes
Sep 27, 2019
kmax12
left a comment
kmax12
left a comment
Contributor
There was a problem hiding this comment.
Docs look good! Just a couple minor comments and it's good to go from me
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to specify which entities or columns a primitive should be applied to (or ignore) as requested in #655