-
Notifications
You must be signed in to change notification settings - Fork 894
add ability to specify primitives per entity or variable #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
==========================================
+ Coverage 97.69% 97.77% +0.08%
==========================================
Files 118 119 +1
Lines 10576 10870 +294
==========================================
+ Hits 10332 10628 +296
+ Misses 244 242 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good overall. Mainly added some comments about presentation in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good! Just a couple minor comments and it's good to go from me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Adds the ability to specify which entities or columns a primitive should be applied to (or ignore) as requested in #655