Added fix and testcase for normalizing with DatetimeTimeIndex entry #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
==========================================
+ Coverage 97.65% 97.65% +<.01%
==========================================
Files 118 118
Lines 10364 10381 +17
==========================================
+ Hits 10121 10138 +17
Misses 243 243
Continue to review full report at Codecov.
|
rwedge
reviewed
Sep 19, 2019
rwedge
reviewed
Sep 19, 2019
featuretools/entityset/entityset.py
Outdated
| @@ -593,6 +598,9 @@ def normalize_entity(self, base_entity_id, new_entity_id, index, | |||
| elif make_time_index: | |||
| # Create a new time index based on the base entity time index. | |||
| base_time_index = base_entity.time_index | |||
| t_index = base_entity[base_time_index] | |||
| if not isinstance(t_index, (vtypes.NumericTimeIndex, vtypes.DatetimeTimeIndex)): | |||
| raise TypeError("{0} is not a NumericTimeIndex or DatetimeTimeIndex, but type {1}".format(base_time_index, type(t_index))) | |||
There was a problem hiding this comment.
Let's start the error message with "Time index {0}" so there's more context about the error. And at the end of the error message we can add a suggestion for fixing it by running set_time_index on the entity.
I think we should make this a sanity check we run any time normalize_entity is called since if this gets triggered the entity is definitely misconfigured
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #740 by setting all DatetimeTimeIndex variables in
additional_variableandcopy_variablesto Datetime