Skip to content

Fix missing groupby features#754

Merged
frances-h merged 7 commits into
masterfrom
fix-missing-features
Sep 25, 2019
Merged

Fix missing groupby features#754
frances-h merged 7 commits into
masterfrom
fix-missing-features

Conversation

@frances-h

Copy link
Copy Markdown
Contributor

Fix issue in #733 that removed some groupby features

@frances-h
frances-h requested a review from rwedge September 25, 2019 15:39
@rwedge

rwedge commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

Can you add a regression test?

@codecov

codecov Bot commented Sep 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #754 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   97.68%   97.68%   +<.01%     
==========================================
  Files         118      118              
  Lines       10543    10549       +6     
==========================================
+ Hits        10299    10305       +6     
  Misses        244      244
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 96.36% <100%> (+0.01%) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 98.71% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5456944...b4064ed. Read the comment docs.

Comment thread featuretools/synthesis/deep_feature_synthesis.py Outdated
Comment thread docs/source/changelog.rst Outdated

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@frances-h
frances-h merged commit 81b9f20 into master Sep 25, 2019
@frances-h
frances-h deleted the fix-missing-features branch September 25, 2019 19:11
@rwedge rwedge mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants