Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing groupby features #754

Merged
merged 7 commits into from
Sep 25, 2019
Merged

Fix missing groupby features #754

merged 7 commits into from
Sep 25, 2019

Conversation

frances-h
Copy link
Contributor

Fix issue in #733 that removed some groupby features

@frances-h frances-h requested a review from rwedge September 25, 2019 15:39
@rwedge
Copy link
Contributor

rwedge commented Sep 25, 2019

Can you add a regression test?

@codecov
Copy link

codecov bot commented Sep 25, 2019 •
edited
Loading

Codecov Report

Merging #754 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   97.68%   97.68%   +<.01%     
==========================================
  Files         118      118              
  Lines       10543    10549       +6     
==========================================
+ Hits        10299    10305       +6     
  Misses        244      244
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 96.36% <100%> (+0.01%) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 98.71% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5456944...b4064ed. Read the comment docs.

rwedge
rwedge reviewed Sep 25, 2019
View reviewed changes
docs/source/changelog.rst Outdated Show resolved Hide resolved
rwedge
rwedge approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@frances-h frances-h merged commit 81b9f20 into master Sep 25, 2019
@frances-h frances-h deleted the fix-missing-features branch September 25, 2019 19:11
@rwedge rwedge mentioned this pull request Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frances-h @rwedge