Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toolz direct dependency #755

merged 6 commits into from Sep 25, 2019


Copy link

@rwedge rwedge commented Sep 25, 2019

This pr removes the one place we directly import the toolz library. It will still get installed due to other dependencies.

Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #755 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #755      +/-   ##
+ Coverage   97.68%   97.68%   +<.01%     
  Files         118      118              
  Lines       10549    10550       +1     
+ Hits        10305    10306       +1     
  Misses        244      244
Impacted Files Coverage Δ
featuretools/tests/utils_tests/ 100% <100%> (ø) ⬆️
featuretools/utils/ 55.31% <100%> (ø) ⬆️
...aturetools/tests/entityset_tests/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b9f20...8506ebb. Read the comment docs.

@rwedge rwedge requested a review from kmax12 September 25, 2019 19:08
Copy link

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@rwedge rwedge merged commit a197dc0 into master Sep 25, 2019
@rwedge rwedge deleted the remove-toolz-direct-dependency branch September 25, 2019 19:57
@rwedge rwedge mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants