-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for boolean variable type in Multiply primitive #756
Conversation
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 97.68% 97.69% +<.01%
==========================================
Files 118 118
Lines 10550 10576 +26
==========================================
+ Hits 10306 10332 +26
Misses 244 244
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
If you have the privileges you can go ahead and merge it in, otherwise I can do it. |
I was able to do it. Do you want me to go ahead and close out the related issue as well? |
Yep! |
Pull Request Description
Update
binary_transform.py
to include support for boolean variable types in theMultiply
primitive. Also, added a test intest_transform_features.py
to confirm this works properly when multiplying numeric by numeric, bool by numeric, and numeric by bool.This PR closes issue #752