Add support for boolean variable type in Multiply primitive#756
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 97.68% 97.69% +<.01%
==========================================
Files 118 118
Lines 10550 10576 +26
==========================================
+ Hits 10306 10332 +26
Misses 244 244
Continue to review full report at Codecov.
|
rwedge
reviewed
Sep 26, 2019
rwedge
reviewed
Sep 26, 2019
rwedge
reviewed
Sep 27, 2019
Contributor
|
If you have the privileges you can go ahead and merge it in, otherwise I can do it. |
Contributor
Author
|
I was able to do it. Do you want me to go ahead and close out the related issue as well? |
Contributor
|
Yep! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Update
binary_transform.pyto include support for boolean variable types in theMultiplyprimitive. Also, added a test intest_transform_features.pyto confirm this works properly when multiplying numeric by numeric, bool by numeric, and numeric by bool.This PR closes issue #752