Skip to content

Add support for boolean variable type in Multiply primitive#756

Merged
thehomebrewnerd merged 9 commits into
masterfrom
allow-bool-in-multiply
Sep 27, 2019
Merged

Add support for boolean variable type in Multiply primitive#756
thehomebrewnerd merged 9 commits into
masterfrom
allow-bool-in-multiply

Conversation

@thehomebrewnerd

Copy link
Copy Markdown
Contributor

Pull Request Description

Update binary_transform.py to include support for boolean variable types in the Multiply primitive. Also, added a test in test_transform_features.py to confirm this works properly when multiplying numeric by numeric, bool by numeric, and numeric by bool.

This PR closes issue #752

@codecov

codecov Bot commented Sep 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #756 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   97.68%   97.69%   +<.01%     
==========================================
  Files         118      118              
  Lines       10550    10576      +26     
==========================================
+ Hits        10306    10332      +26     
  Misses        244      244
Impacted Files Coverage Δ
...aturetools/primitives/standard/binary_transform.py 100% <100%> (ø) ⬆️
featuretools/feature_base/feature_base.py 97.89% <100%> (+0.01%) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.4% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a197dc0...fd568eb. Read the comment docs.

@kmax12 kmax12 requested review from rwedge and removed request for kmax12 September 26, 2019 17:59
Comment thread docs/source/changelog.rst Outdated
Comment thread featuretools/primitives/standard/binary_transform.py
Comment thread featuretools/tests/primitive_tests/test_transform_features.py Outdated

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rwedge

rwedge commented Sep 27, 2019

Copy link
Copy Markdown
Contributor

If you have the privileges you can go ahead and merge it in, otherwise I can do it.

@thehomebrewnerd thehomebrewnerd merged commit aab3894 into master Sep 27, 2019
@thehomebrewnerd thehomebrewnerd deleted the allow-bool-in-multiply branch September 27, 2019 16:42
@thehomebrewnerd

Copy link
Copy Markdown
Contributor Author

I was able to do it. Do you want me to go ahead and close out the related issue as well?

@rwedge

rwedge commented Sep 27, 2019

Copy link
Copy Markdown
Contributor

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants