Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for boolean variable type in Multiply primitive #756

merged 9 commits into from Sep 27, 2019


Copy link

Pull Request Description

Update to include support for boolean variable types in the Multiply primitive. Also, added a test in to confirm this works properly when multiplying numeric by numeric, bool by numeric, and numeric by bool.

This PR closes issue #752

Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #756 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
+ Coverage   97.68%   97.69%   +<.01%     
  Files         118      118              
  Lines       10550    10576      +26     
+ Hits        10306    10332      +26     
  Misses        244      244
Impacted Files Coverage Δ
...aturetools/primitives/standard/ 100% <100%> (ø) ⬆️
featuretools/feature_base/ 97.89% <100%> (+0.01%) ⬆️
...s/tests/primitive_tests/ 98.4% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a197dc0...fd568eb. Read the comment docs.

@kmax12 kmax12 requested review from rwedge and removed request for kmax12 September 26, 2019 17:59
docs/source/changelog.rst Outdated Show resolved Hide resolved
rwedge approved these changes Sep 27, 2019
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

rwedge commented Sep 27, 2019

If you have the privileges you can go ahead and merge it in, otherwise I can do it.

@thehomebrewnerd thehomebrewnerd merged commit aab3894 into master Sep 27, 2019
@thehomebrewnerd thehomebrewnerd deleted the allow-bool-in-multiply branch September 27, 2019 16:42
Copy link
Collaborator Author

I was able to do it. Do you want me to go ahead and close out the related issue as well?

Copy link

rwedge commented Sep 27, 2019


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants