Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2 support #759

Merged
merged 24 commits into from Oct 7, 2019
Merged

Drop python 2 support #759

merged 24 commits into from Oct 7, 2019

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Oct 1, 2019

This PR removes Python 2 support from Featuretools

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #759 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   97.76%   97.97%   +0.21%     
==========================================
  Files         119      119              
  Lines       10861    10772      -89     
==========================================
- Hits        10618    10554      -64     
+ Misses        243      218      -25
Impacted Files Coverage Δ
featuretools/computational_backends/feature_set.py 100% <ø> (ø) ⬆️
featuretools/feature_base/feature_base.py 97.88% <ø> (-0.01%) ⬇️
featuretools/utils/cli_utils.py 55.31% <ø> (ø) ⬆️
featuretools/wrappers/sklearn.py 95.45% <ø> (-0.11%) ⬇️
featuretools/utils/entity_utils.py 98.03% <ø> (-0.02%) ⬇️
...aturetools/primitives/standard/binary_transform.py 100% <ø> (ø) ⬆️
...eaturetools/tests/utils_tests/test_entity_utils.py 100% <ø> (ø) ⬆️
...eaturetools/tests/entityset_tests/test_plotting.py 100% <ø> (ø) ⬆️
...computational_backends/calculate_feature_matrix.py 98.22% <ø> (-0.02%) ⬇️
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.06% <ø> (ø) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21d639...b8b78f6. Read the comment docs.

Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rwedge rwedge changed the title [WIP] Drop python 2 support Drop python 2 support Oct 7, 2019
@rwedge rwedge merged commit 18e929d into master Oct 7, 2019
@rwedge rwedge deleted the drop-python-2 branch October 7, 2019 19:31
@rwedge rwedge mentioned this pull request Oct 31, 2019
@kmax12 kmax12 mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants