Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit parameter to AvgTimeBetween #771

Merged
merged 6 commits into from Oct 16, 2019
Merged

Add unit parameter to AvgTimeBetween #771

merged 6 commits into from Oct 16, 2019

Conversation

jeffzi
Copy link
Contributor

@jeffzi jeffzi commented Oct 13, 2019

Added unit parameter to AvgTimeBetween

This PR adds a unit parameter to AvgTimeBetween primitive, similary to TimeSinceFirst, TimeSinceLast and TimeSincePrevious.

@jeffzi jeffzi changed the title Avg time between Add unit parameter to AvgTimeBetween Oct 13, 2019
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

rwedge
rwedge requested changes Oct 16, 2019
View changes
Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffzi

Thanks for the PR! I left some comments

docs/source/changelog.rst Outdated Show resolved Hide resolved
featuretools/primitives/standard/aggregation_primitives.py Outdated Show resolved Hide resolved
rwedge
rwedge approved these changes Oct 16, 2019
View changes
Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rwedge rwedge merged commit 9aee69d into alteryx:master Oct 16, 2019
@rwedge rwedge mentioned this pull request Oct 31, 2019
Merged
@jeffzi jeffzi deleted the avg_time_between branch December 5, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffzi @CLAassistant @rwedge