Skip to content

Add unit parameter to AvgTimeBetween#771

Merged
rwedge merged 6 commits into
alteryx:masterfrom
jeffzi:avg_time_between
Oct 16, 2019
Merged

Add unit parameter to AvgTimeBetween#771
rwedge merged 6 commits into
alteryx:masterfrom
jeffzi:avg_time_between

Conversation

@jeffzi

@jeffzi jeffzi commented Oct 13, 2019

Copy link
Copy Markdown
Contributor

Added unit parameter to AvgTimeBetween

This PR adds a unit parameter to AvgTimeBetween primitive, similary to TimeSinceFirst, TimeSinceLast and TimeSincePrevious.

@jeffzi jeffzi changed the title Avg time between Add unit parameter to AvgTimeBetween Oct 13, 2019
@CLAassistant

CLAassistant commented Oct 14, 2019

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffzi

Thanks for the PR! I left some comments

Comment thread docs/source/changelog.rst Outdated
Comment thread featuretools/primitives/standard/aggregation_primitives.py Outdated

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rwedge rwedge merged commit 9aee69d into alteryx:master Oct 16, 2019
@rwedge rwedge mentioned this pull request Oct 31, 2019
@jeffzi jeffzi deleted the avg_time_between branch December 5, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants