Repository navigation
Custom naming for multi output primitives - #780
Merged
Merged
Conversation
|
|
rwedge
reviewed
Oct 24, 2019
rwedge
left a comment
rwedge
left a comment
Contributor
There was a problem hiding this comment.
I think GroupByTransformFeature should also implement generate_names
rwedge
reviewed
Oct 25, 2019
rwedge
reviewed
Oct 30, 2019
| f = 'MULTI_CUM_SUM(age) by région_id[%d]' % i | ||
| f = 'MULTI_CUM_SUM(age)[%d] by région_id' % i | ||
| assert f in fm.columns | ||
| for x, y in zip(fm[f].values, correct_answers[i][1].values): |
Contributor
There was a problem hiding this comment.
For this test, can we also calculate the standard groupby features in a separate DFS call and compare, to see if the multioutput code path alters any values?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Updates to allow for custom naming of multioutput primitives. Implements a
generate_namesmethod inPrimitiveBaseclass that can be overridden when creating a custom primitive.This change was discussed in Issues #591 and #593.