Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when multioutput primitives supplied to dfs as groupby primitive #786

Merged
merged 8 commits into from
Oct 29, 2019

Conversation

thehomebrewnerd
Copy link
Contributor

Pull Request Description

Fixes an issue that occurred when multi-output primitive was supplied as a groupby_trans_primitives parameter during ft.dfs.

Closes issue #785.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the test, can the primitive have different outputs per column so we can check the values?

Maybe have it do CumSum, CumMa, etc, and compare the results with the standard primitives?

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants