Fix issue when multioutput primitives supplied to dfs as groupby primitive#786
Merged
thehomebrewnerd merged 8 commits intomasterfrom Oct 29, 2019
Merged
Fix issue when multioutput primitives supplied to dfs as groupby primitive#786thehomebrewnerd merged 8 commits intomasterfrom
thehomebrewnerd merged 8 commits intomasterfrom
Conversation
rwedge
reviewed
Oct 25, 2019
Contributor
rwedge
left a comment
rwedge
left a comment
There was a problem hiding this comment.
For the test, can the primitive have different outputs per column so we can check the values?
Maybe have it do CumSum, CumMa, etc, and compare the results with the standard primitives?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes an issue that occurred when multi-output primitive was supplied as a
groupby_trans_primitivesparameter duringft.dfs.Closes issue #785.