Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests in windows environment #790

Merged
merged 74 commits into from Dec 3, 2019
Merged

Run unit tests in windows environment #790

merged 74 commits into from Dec 3, 2019

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Oct 29, 2019 •
edited by kmax12

fixes #781

@rwedge
use windows orb
9471e88
@rwedge
add executor to windows job
134fd95
@rwedge
use windows-based container image for python
524ddfe
@rwedge
remove unnecessary flag
31a051b
@rwedge
get working directory
8aea2e5
@rwedge
try mounting a folder
646f8a7
@rwedge
make virtual environment
42d0a8c
@rwedge
separate pulling image into a different step
ea95f04
@rwedge
activate virtual environment and upgrade pip
2a2a1ca
@rwedge
try fixing env activation
d6ebc7e
@rwedge
enclose command in quotes so all commands are executed in container
b52daf0
@rwedge
upgrade pip
e51cd2f
@rwedge
Merge branch 'master' into windows-ci
51d6358
@rwedge
use powershell -Command
441474b
@rwedge
activate virtual environment
b498bb2
@rwedge
split command onto multiple lines; install ft and run pytest
e27bf77
@rwedge
add \ marks to end of lines
f04d4bb
@rwedge
remove \
8727cf1
@rwedge
check current directory contents
61c6083
@rwedge
mount featuretools folder into docker container
0d5315c
@rwedge
check if python is installed on vm
d3bafff
@kmax12 kmax12 mentioned this pull request Nov 11, 2019
Closed
@rwedge
format step names
9231d17
@rwedge
install graphviz
1444745
@rwedge
Merge branch 'master' into windows-ci
7d492a1
@rwedge
Install graphviz instead of python-graphviz
cf8c2ce
@rwedge
switch back to python-graphviz
b59099d
@rwedge
remove colons from temp tar filename
0dce350
@rwedge
use double quotes to check error messages
9060fd7
@rwedge
rename task now that only graphviz is installed
e4397f2
@rwedge
remove exact file path in error message
fc2a603
@rwedge
Merge branch 'master' into windows-ci
ce6648c
@rwedge
try raw string pattern
e942bb9
@rwedge
Merge branch 'master' into windows-ci
4d4e6a4
@rwedge
avoid using match due to windows paths using escape character
c229af7
@rwedge
add encoding kwarg when loading features using s3fs
8dd7f2a
@rwedge
test multiple windows versions
dd4719b
@rwedge
flip slash direction
db28309
@rwedge
fix uri
cb9c473
@rwedge
use back slash instead of escape character
5377efb
@rwedge
Merge branch 'master' into windows-ci
93c0639
@rwedge
add back original tests
d9736d1
@codecov-io
Copy link

codecov-io commented Dec 2, 2019 •
edited

Codecov Report

Merging #790 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   98.15%   98.15%   +<.01%     
==========================================
  Files         121      121              
  Lines       10939    10941       +2     
==========================================
+ Hits        10737    10739       +2     
  Misses        202      202
Impacted Files Coverage Δ
featuretools/entityset/serialize.py 98.66% <100%> (ø) ⬆️
...ools/tests/primitive_tests/test_primitive_utils.py 100% <100%> (ø) ⬆️
featuretools/utils/s3_utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aad8ee...f819cff. Read the comment docs.

@rwedge rwedge changed the title [WIP] Run unit tests in windows environment Run unit tests in windows environment Dec 2, 2019
christopherbunn
christopherbunn approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@christopherbunn christopherbunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwedge rwedge merged commit cd674b3 into master Dec 3, 2019
@rwedge rwedge deleted the windows-ci branch December 20, 2019 00:16
@rwedge rwedge mentioned this pull request Dec 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherbunn christopherbunn christopherbunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests on windows
3 participants
@rwedge @codecov-io @christopherbunn