Primitive option fix#807
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #807 +/- ##
==========================================
+ Coverage 98.12% 98.12% +<.01%
==========================================
Files 119 119
Lines 10875 10877 +2
==========================================
+ Hits 10671 10673 +2
Misses 204 204
Continue to review full report at Codecov.
|
frances-h
force-pushed
the
primitive-option-fix
branch
from
058e88a to
6e571f1
Compare
rwedge
reviewed
Nov 19, 2019
frances-h
force-pushed
the
primitive-option-fix
branch
from
5f4f4bb to
ba75542
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix how primitive options are applied to prevent issues where options were being ignored