Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primitive option fix #807

Merged
merged 18 commits into from
Nov 20, 2019
Merged

Primitive option fix #807

merged 18 commits into from
Nov 20, 2019

Conversation

frances-h
Copy link
Contributor

Fix how primitive options are applied to prevent issues where options were being ignored

@frances-h frances-h requested a review from rwedge November 11, 2019 17:31
@frances-h frances-h changed the title [WIP] primitive option fix primitive option fix Nov 11, 2019
@frances-h frances-h changed the title primitive option fix Primitive option fix Nov 11, 2019
@codecov-io
Copy link

codecov-io commented Nov 18, 2019 •
edited
Loading

Codecov Report

Merging #807 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   98.12%   98.12%   +<.01%     
==========================================
  Files         119      119              
  Lines       10875    10877       +2     
==========================================
+ Hits        10671    10673       +2     
  Misses        204      204
Impacted Files Coverage Δ
featuretools/primitives/options_utils.py 100% <100%> (ø) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205fa1b...5ad7557. Read the comment docs.

@frances-h frances-h force-pushed the primitive-option-fix branch from 058e88a to 6e571f1 Compare November 19, 2019 00:05
@frances-h frances-h changed the title Primitive option fix [WIP] Primitive option fix Nov 19, 2019
@frances-h frances-h changed the title [WIP] Primitive option fix Primitive option fix Nov 19, 2019
@frances-h frances-h force-pushed the primitive-option-fix branch from 5f4f4bb to ba75542 Compare November 20, 2019 15:13
rwedge
rwedge approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frances-h frances-h merged commit ead2e91 into master Nov 20, 2019
@frances-h frances-h deleted the primitive-option-fix branch November 20, 2019 16:00
@rwedge rwedge mentioned this pull request Nov 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frances-h @codecov-io @rwedge