Skip to content

drop python 2.7 from serialize.py #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

systemshift
Copy link
Contributor

@systemshift systemshift commented Nov 12, 2019

Pull Request Description

from the discussion started in #797 and issue #808. A line to support a special case for 2.7 support has been removed.
all tests pass after removing the line.
11 warnings show, but the same number has been there before this commit.

It might be wise to investigate if the 11 warnings are exactly the same. Or if removing the line removed one warning, and a new one has replaced it.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the warning logs against another branch, the warnings were the same

Looks good!

@rwedge rwedge merged commit 606c0c0 into alteryx:master Nov 14, 2019
@systemshift systemshift deleted the remove_py_2.7_serialize.py branch November 21, 2019 16:07
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants