drop python 2.7 from serialize.py - #812
Merged
Merged
Conversation
rwedge
approved these changes
Nov 14, 2019
rwedge
left a comment
rwedge
left a comment
Contributor
There was a problem hiding this comment.
I checked the warning logs against another branch, the warnings were the same
Looks good!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
from the discussion started in #797 and issue #808. A line to support a special case for 2.7 support has been removed.
all tests pass after removing the line.
11 warnings show, but the same number has been there before this commit.
It might be wise to investigate if the 11 warnings are exactly the same. Or if removing the line removed one warning, and a new one has replaced it.
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request.