Skip to content

Refactor make_ecommerce_entityset - #813

Merged
frances-h merged 9 commits into
masterfrom
refactor-make-ecommerce-entityset
Nov 14, 2019
Merged

Refactor make_ecommerce_entityset#813
frances-h merged 9 commits into
masterfrom
refactor-make-ecommerce-entityset

Conversation

@frances-h

@frances-h frances-h commented Nov 13, 2019

Copy link
Copy Markdown
Contributor
  • Refactor make_ecommerce_entityset to directly use created dataframes to generate the entityset instead of saving the dataframes to csv first.
  • Update tests to only create entityset once and use deep copies as copying is faster.
  • Sort entities by id when serializing entityset

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@frances-h frances-h changed the title Refactor make ecommerce entityset Refactor make_ecommerce_entityset Nov 13, 2019
@frances-h
frances-h requested a review from rwedge November 13, 2019 20:02
@frances-h frances-h changed the title Refactor make_ecommerce_entityset [WIP] Refactor make_ecommerce_entityset Nov 13, 2019
@frances-h frances-h changed the title [WIP] Refactor make_ecommerce_entityset Refactor make_ecommerce_entityset Nov 14, 2019
@frances-h frances-h mentioned this pull request Nov 14, 2019
Comment thread featuretools/tests/testing_utils/mock_ds.py Outdated
Comment thread featuretools/tests/testing_utils/mock_ds.py Outdated

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frances-h
frances-h merged commit 372f513 into master Nov 14, 2019
@frances-h
frances-h deleted the refactor-make-ecommerce-entityset branch November 14, 2019 21:16
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants