New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove get_values() from test_es.py #820
remove get_values() from test_es.py #820
Conversation
@@ -128,7 +128,7 @@ def test_query_by_id_with_time(es): | |||
instance_vals=[0, 1, 2, 3, 4], | |||
time_last=datetime(2011, 4, 9, 10, 30, 2 * 6)) | |||
|
|||
assert df['id'].get_values().tolist() == [0, 1, 2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does df['id'].tolist()
work as well? It would be simpler
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 119 119
Lines 10875 10875
=======================================
Hits 10671 10671
Misses 204 204
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Pull Request Description
Replace deprecating get_values with to_numpy() to remove warnings when running tests
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rst
to include this pull request.