remove get_values() from test_es.py #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwedge
reviewed
Nov 19, 2019
| @@ -128,7 +128,7 @@ def test_query_by_id_with_time(es): | |||
| instance_vals=[0, 1, 2, 3, 4], | |||
| time_last=datetime(2011, 4, 9, 10, 30, 2 * 6)) | |||
|
|
|||
| assert df['id'].get_values().tolist() == [0, 1, 2] | |||
There was a problem hiding this comment.
does df['id'].tolist() work as well? It would be simpler
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 119 119
Lines 10875 10875
=======================================
Hits 10671 10671
Misses 204 204
Continue to review full report at Codecov.
|
systemshift
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Replace deprecating get_values with to_numpy() to remove warnings when running tests
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request.