Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove get_values() from #820

merged 5 commits into from Nov 20, 2019


Copy link

Pull Request Description

Replace deprecating get_values with to_numpy() to remove warnings when running tests

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@@ -128,7 +128,7 @@ def test_query_by_id_with_time(es):
instance_vals=[0, 1, 2, 3, 4],
time_last=datetime(2011, 4, 9, 10, 30, 2 * 6))

assert df['id'].get_values().tolist() == [0, 1, 2]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does df['id'].tolist() work as well? It would be simpler

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #820 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #820   +/-   ##
  Coverage   98.12%   98.12%           
  Files         119      119           
  Lines       10875    10875           
  Hits        10671    10671           
  Misses        204      204
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 853091d...ddd2393. Read the comment docs.

@systemshift systemshift changed the title replace get_values() with to_numpy() remove get_values() from Nov 20, 2019
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rwedge rwedge merged commit 205fa1b into alteryx:master Nov 20, 2019
@systemshift systemshift deleted the replace_get_values_with_to_numpy branch November 21, 2019 16:06
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants