-
Notifications
You must be signed in to change notification settings - Fork 897
Diff uses full entity #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
==========================================
+ Coverage 98.12% 98.12% +<.01%
==========================================
Files 119 119
Lines 10882 10897 +15
==========================================
+ Hits 10678 10693 +15
Misses 204 204
Continue to review full report at Codecov.
|
Pull Request Description
Fixes how the Diff primitive is calculated so that it will use all available data when calculating diff. This should make returned values more predictable.
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rst
to include this pull request.