Conversation
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
=========================================
Coverage ? 98.16%
=========================================
Files ? 117
Lines ? 10808
Branches ? 0
=========================================
Hits ? 10610
Misses ? 198
Partials ? 0
Continue to review full report at Codecov.
|
kmax12
approved these changes
Jan 24, 2020
Contributor
kmax12
left a comment
kmax12
left a comment
There was a problem hiding this comment.
Looks good. Nice code clean up
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a suggestion from piskvorky/smart_open/issues/250, we can use the smart_open library in all cases where we upload and download from s3, removing the need to use the s3fs library.
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request.