New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make S3 libraries optional #827
Conversation
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
==========================================
+ Coverage 98.12% 98.15% +0.02%
==========================================
Files 119 121 +2
Lines 10897 10920 +23
==========================================
+ Hits 10693 10718 +25
+ Misses 204 202 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, otherwise looking good
from featuretools.utils.gen_utils import import_or_raise | ||
|
||
|
||
def test_import_or_raise_errors(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe also add a test that it correct does the import too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR make smart_open, boto3, and s3fs optional dependencies, similar to graphviz.
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rst
to include this pull request.