Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make S3 libraries optional #827

Merged
merged 10 commits into from Nov 22, 2019
Merged

Make S3 libraries optional #827

merged 10 commits into from Nov 22, 2019

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Nov 22, 2019

This PR make smart_open, boto3, and s3fs optional dependencies, similar to graphviz.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #827 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
+ Coverage   98.12%   98.15%   +0.02%     
==========================================
  Files         119      121       +2     
  Lines       10897    10920      +23     
==========================================
+ Hits        10693    10718      +25     
+ Misses        204      202       -2
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 96.48% <100%> (+0.52%) ⬆️
featuretools/feature_base/features_serializer.py 98.07% <100%> (+0.03%) ⬆️
featuretools/feature_base/features_deserializer.py 100% <100%> (ø) ⬆️
featuretools/tests/utils_tests/test_gen_utils.py 100% <100%> (ø)
featuretools/entityset/deserialize.py 100% <100%> (ø) ⬆️
featuretools/utils/s3_utils.py 100% <100%> (ø)
featuretools/entityset/serialize.py 98.66% <100%> (+0.01%) ⬆️
featuretools/utils/gen_utils.py 91.07% <100%> (-2.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa87c9...5931f0f. Read the comment docs.

@rwedge rwedge requested a review from kmax12 November 22, 2019 14:15
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, otherwise looking good

from featuretools.utils.gen_utils import import_or_raise


def test_import_or_raise_errors():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also add a test that it correct does the import too?

docs/source/changelog.rst Show resolved Hide resolved
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwedge rwedge merged commit 0bef172 into master Nov 22, 2019
@rwedge rwedge mentioned this pull request Nov 30, 2019
@rwedge rwedge deleted the boto-optional branch February 19, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants