Make S3 libraries optional - #827
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
==========================================
+ Coverage 98.12% 98.15% +0.02%
==========================================
Files 119 121 +2
Lines 10897 10920 +23
==========================================
+ Hits 10693 10718 +25
+ Misses 204 202 -2
Continue to review full report at Codecov.
|
kmax12
suggested changes
Nov 22, 2019
kmax12
left a comment
kmax12
left a comment
Contributor
There was a problem hiding this comment.
minor comments, otherwise looking good
| from featuretools.utils.gen_utils import import_or_raise | ||
|
|
||
|
|
||
| def test_import_or_raise_errors(): |
Contributor
There was a problem hiding this comment.
maybe also add a test that it correct does the import too?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR make smart_open, boto3, and s3fs optional dependencies, similar to graphviz.
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request.